Render noExpander icon from icon map for leaf nodes #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not the right answer and should not be merged: it works for FontAwesome where the .fa class is a good way to get an empty space. I don't know whether glyph icons has anything similar. And this doesn't solve the problem for non-glyph rendering. For reference, this patch requires this as part of a fontawesome config for the glyph extension: ```glyph:{map:{noExpander:"fa"}}```
|
Did you try with |
|
@mar10 I tried this out last night: works well, thanks for merging. |
|
thanks for contributing. I merged locally and lost your commit history; sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making this PR to highlight a feature request (no expander icons on leaf nodes), and to propose one limited solution for my specific use-case.
This is not the right answer and should not be merged: it works for FontAwesome where the .fa class is a good way to get an empty space. I don't know whether glyphicons has anything similar. And this patch doesn't solve the problem for non-glyph rendering where an empty image is probably required.
For reference, this patch requires this as part of a fontawesome config for the glyph extension:
glyph:{map:{noExpander:"fa"}}