ext-dnd: options for drop marker offset #693
Conversation
…pMarkerOffsetBefore/dropMarkerOffsetAfter)
src/jquery.fancytree.dnd.js
Outdated
| break; | ||
| case "after": | ||
| markerAt = "bottom"; | ||
| markerOffsetX -= 16; | ||
| markerOffsetX += (dndOpt.dropMarkerOffsetAfter || 0); |
There was a problem hiding this comment.
This offset will always be the same for 'after' and 'before' so I suggest to combine it into one single option.
Also we could use two positive defaults:
dropMarkerOffsetX: 8
dropMarkerOffsetIndentX: 16
before/after offset will be dropMarkerOffsetX
otherwise dropMarkerOffsetX + dropMarkerOffsetIndentX
There was a problem hiding this comment.
I thought about positive values, but if before/after offsets are evaluating as a sum of two options (dropMarkerOffset+dropMarkerOffsetAfter) then it'd be unclear for me what to specify as dropMarkerOffsetAfter: negative value (-16) or positive (+16).
I think I'd make sense only if we'll have two separated options (offsetOver/offsetInsert) which won't be summed.
This offset will always be the same for 'after' and 'before' so I suggest to combine it into one single option.
Ok
Also we could use two positive defaults:
dropMarkerOffsetX: 8
dropMarkerOffsetIndentX: 16
I'm sorry, I don't understand, why 8/16? They are -24 and -16 currently, aren't them?
…fsetX/dropMarkerInsertOffsetX) instead of three ext-dnd5: setting drop marker offset via options (the same as for etx-dnd)
Hard-coded offset for drop marker was replaced by usage of values from extension's options (
dropMarkerOffset/dropMarkerOffsetBefore/dropMarkerOffsetAfter).