Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Add exclude flag to list and pack commands #112

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jankaszel
Copy link

@jankaszel jankaszel commented Jul 22, 2020

Continuing work from #108 on adding an -exclude flag for ignoring particular directories to both the list and pack commands. Includes tests and documentation.

Tests fail at the moment. This is due to bugs within the testing framework as I've laid out in #108 (comment):

Tests fail though, as they do on the main branch atm. @markbates to me it occurs that there is a bug in pkging/pkgtest that will somehow keep references to the first directory created by pkgtest.NewRef() for subsequent tests. As the first directory will be deleted after the first test passed, subsequent tests will fail due to the missing directory. Didn't find a solution for that bug, but if you comment out line 26 in the above parser_test.go, tests for the excludes argument will pass.

@jankaszel
Copy link
Author

@markbates cheers, any plans to get this merged?

@aeneasr
Copy link

aeneasr commented Aug 26, 2020

Would be great if this could be merged!

@cornelk
Copy link

cornelk commented Nov 9, 2020

@markbates any chance to get this merged?

@jankaszel
Copy link
Author

FYI the embed library introduced in Go 1.16 could offer a viable alternative for folks running into issues with pkger related to large directories that should be ignored: https://golang.org/doc/go1.16#library-embed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants