Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Use base64-encoding in favor of hex-encoding #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BattleRattle
Copy link

Hi 👋,

I noticed, that the embedded data is serialized using hex-encoding, which increases the file size of the generated pkged.go as well as the compiled binary. Using base64-encoding instead can reduce this overhead and is also only a small code change.

Hex-encoding has a ratio of 2:1, so every (gzipped) byte translates to 2 bytes of serialized data.
On the other hand base64-encoding only has a ratio of 4:3, so every 3 bytes of (gzipped) data result in 4 bytes of serialized data.

So with this commit every MB of packaged assets (after gzip) only ends up in ~1,333 MB instead of 2 MB in the binary.

@Zikoel
Copy link

Zikoel commented Nov 22, 2020

Why this pull request is still pending ? Seems very useful and very simple!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants