This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
Use base64-encoding in favor of hex-encoding #123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋,
I noticed, that the embedded data is serialized using hex-encoding, which increases the file size of the generated
pkged.go
as well as the compiled binary. Using base64-encoding instead can reduce this overhead and is also only a small code change.Hex-encoding has a ratio of 2:1, so every (gzipped) byte translates to 2 bytes of serialized data.
On the other hand base64-encoding only has a ratio of 4:3, so every 3 bytes of (gzipped) data result in 4 bytes of serialized data.
So with this commit every MB of packaged assets (after gzip) only ends up in ~1,333 MB instead of 2 MB in the binary.