Addressed Rubocop concerns from PR 29 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rubocop checks in PR marketplacer#29 did not fire, so issues were not discovered until release. This corrects them, making Rubocop and tests pass. - GTIN module was 31 lines (max 30), so I inlined a guard clause - Use of redundant `self.` was removed - Prefer `__send__` over `send` when `public_send` is not an option
beet
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubocop checks in PR #29 did not fire, so small style issues were not discovered until an attempted release. This corrects them, making Rubocop pass. Tests also still pass on my machine.
self.was removed__send__oversendwhenpublic_sendis not an option