code review

marmelab · Jul 10, 2019 · 3548e8d · 3548e8d
1 parent 3a983d9
commit 3548e8d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/packages/ra-core/src/controller/usePaginationState.ts b/packages/ra-core/src/controller/usePaginationState.ts
@@ -1,4 +1,4 @@
-import { useState, useEffect, useReducer, useMemo, useRef } from 'react';
+import { useState, useEffect, useReducer, useCallback, useRef } from 'react';
 import { Pagination } from '../types';
 
 interface PaginationProps {
@@ -10,7 +10,10 @@ interface PaginationProps {
     setPagination: (pagination: Pagination) => void;
 }
 
-const paginationReducer = (prevState, nextState) => {
+const paginationReducer = (
+    prevState: Pagination,
+    nextState: Partial<Pagination>
+): Pagination => {
     return {
         ...prevState,
         ...nextState,
@@ -56,8 +59,8 @@ export default (
     });
     const isFirstRender = useRef(true);
 
-    const setPerPage = useMemo(() => perPage => setPagination({ perPage }), []);
-    const setPage = useMemo(() => page => setPagination({ page }), []);
+    const setPerPage = useCallback(perPage => setPagination({ perPage }), []);
+    const setPage = useCallback(page => setPagination({ page }), []);
 
     useEffect(() => {
         if (isFirstRender.current) {

diff --git a/packages/ra-core/src/controller/useSortState.spec.ts b/packages/ra-core/src/controller/useSortState.spec.ts
@@ -34,7 +34,7 @@ describe('useSortState', () => {
         });
     });
 
-    describe('should provide setSortField method that', () => {
+    describe('setSortField in return value', () => {
         it('should just change the order if receiving the current field', () => {
             const { hookValue, childrenMock } = renderHook(() =>
                 useSortState({ field: 'id', order: 'DESC' })