Apply review

marmelab · Feb 15, 2021 · 54a08a2 · 54a08a2
1 parent adb836a
commit 54a08a2
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/packages/ra-ui-materialui/src/form/FormTabHeader.tsx b/packages/ra-ui-materialui/src/form/FormTabHeader.tsx
@@ -1,4 +1,5 @@
 import * as React from 'react';
+import { useEffect } from 'react';
 import { Link, useLocation } from 'react-router-dom';
 import MuiTab from '@material-ui/core/Tab';
 import classnames from 'classnames';
@@ -18,14 +19,19 @@ export const FormTabHeader = ({
     const formGroup = useFormGroup(value);
     const form = useForm();
     const [showError, setShowError] = React.useState(false);
-    form.subscribe(
-        state => {
-            if (!showError && (state.submitting || state.submitFailed)) {
-                setShowError(true);
-            }
-        },
-        { submitting: true, submitFailed: true }
-    );
+
+    useEffect(() => {
+        const unsubscribe = form.subscribe(
+            state => {
+                if (!showError && (state.submitting || state.submitFailed)) {
+                    setShowError(true);
+                }
+            },
+            { submitting: true, submitFailed: true }
+        );
+
+        return unsubscribe;
+    }, [form, showError]);
 
     return (
         <MuiTab

diff --git a/packages/ra-ui-materialui/src/form/index.tsx b/packages/ra-ui-materialui/src/form/index.tsx
@@ -8,6 +8,7 @@ import TabbedForm, { TabbedFormProps } from './TabbedForm';
 import TabbedFormTabs from './TabbedFormTabs';
 import Toolbar, { ToolbarProps } from './Toolbar';
 import getFormInitialValues from './getFormInitialValues';
+export * from './FormTabHeader';
 
 export type {
     SimpleFormProps,