Merge pull request #3275 from slecoustre/fix-performance-getFetchedAt

optimize getFetchedAt.ts
marmelab · May 24, 2019 · 71de47a · 71de47a
2 parents f45bf90 + cb717ba
commit 71de47a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 20 deletions.
diff --git a/packages/ra-core/src/reducer/admin/resource/data.ts b/packages/ra-core/src/reducer/admin/resource/data.ts
@@ -65,23 +65,17 @@ export const addRecords = (
     newRecords: Record[] = [],
     oldRecords: RecordSetWithDate
 ): RecordSetWithDate => {
-    const newRecordsById = newRecords.reduce(
-        (acc, record) => ({
-            ...acc,
-            [record.id]: record,
-        }),
-        {}
-    );
+    const newRecordsById = {};
+    newRecords.forEach(record => (newRecordsById[record.id] = record));
+
     const newFetchedAt = getFetchedAt(
         newRecords.map(({ id }) => id),
         oldRecords.fetchedAt
     );
-    const records = Object.keys(newFetchedAt).reduce(
-        (acc, id) => ({
-            ...acc,
-            [id]: newRecordsById[id] || oldRecords[id],
-        }),
-        { fetchedAt: newFetchedAt }
+
+    const records = { fetchedAt: newFetchedAt };
+    Object.keys(newFetchedAt).forEach(
+        id => (records[id] = newRecordsById[id] || oldRecords[id])
     );
 
     return hideFetchedAt(records);

diff --git a/packages/ra-core/src/util/getFetchedAt.ts b/packages/ra-core/src/util/getFetchedAt.ts
@@ -37,13 +37,9 @@ const getFetchedAt = (
     cacheDuration = defaultCacheDuration
 ): FetchedOutDates => {
     // prepare new records and timestamp them
-    const newFetchedAt = newRecordIds.reduce(
-        (prev, recordId) => ({
-            ...prev,
-            [recordId]: now,
-        }),
-        {}
-    );
+    const newFetchedAt = {};
+    newRecordIds.forEach(recordId => (newFetchedAt[recordId] = now));
+
     // remove outdated entry
     const latestValidDate = new Date();
     latestValidDate.setTime(latestValidDate.getTime() - cacheDuration);