SimpleList was using the wrong loading prop

Since there is already an early return with the loaded prop, checking the loading prop is not needed. The ReviewMobileList component in the demo has also been fixed (it's coming from the SimpleList component).
marmelab · May 30, 2020 · c2dd003 · c2dd003
1 parent 332335c
commit c2dd003
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/examples/demo/src/reviews/ReviewListMobile.js b/examples/demo/src/reviews/ReviewListMobile.js
@@ -29,10 +29,10 @@ const useStyles = makeStyles({
     },
 });
 
-const ReviewMobileList = ({ basePath, data, ids, loading, total }) => {
+const ReviewMobileList = ({ basePath, data, ids, loaded, total }) => {
     const classes = useStyles();
     return (
-        (loading || total > 0) && (
+        (loaded || total > 0) && (
             <List className={classes.root}>
                 {ids.map(id => (
                     <Link

diff --git a/packages/ra-ui-materialui/src/list/SimpleList.js b/packages/ra-ui-materialui/src/list/SimpleList.js
@@ -96,7 +96,7 @@ const SimpleList = props => {
     }
 
     return (
-        (loading || total > 0) && (
+        (loaded || total > 0) && (
             <List className={className} {...sanitizeListRestProps(rest)}>
                 {ids.map(id => (
                     <LinkOrNot