-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFR] Demo improvements #2799
[RFR] Demo improvements #2799
Conversation
fzaninotto
commented
Jan 22, 2019
•
edited
Loading
edited
- Add a two-level menu
- Add a loader to the posters list
- Generate invoices in the data generator
- Add an Invoice list with expand
- Display the Review detail on the side of the list
- Use a normal Edit view on Mobile
|
||
const InvoiceList = props => ( | ||
<List {...props} filters={<ListFilters />} perPage={25}> | ||
<Datagrid expand={<ShowGuesser />}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the ShowGuesser does not allow you to override the title
prop. It can be seen in the last screenshot: there are two titles concatenated (list and show) when expanding an line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the next commit. I only used the guesser temporarily.
Switching to RFR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈