Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to display CheckboxGroupInput as a column #2947

Closed
wants to merge 1 commit into from
Closed

Added possibility to display CheckboxGroupInput as a column #2947

wants to merge 1 commit into from

Conversation

dobryanskyy
Copy link

No description provided.

@fzaninotto
Copy link
Member

Can you please add a screenshot?
What's the use case?
Can you PR against next instead of master, as it's anew feature?
I'm not fan of passing ‘false‘ to disable an option. Can't you name the option column instead?
Also, please update the documentation.

@@ -86,6 +86,8 @@ const styles = theme => ({
* @example
* <CheckboxGroupInput source="gender" choices={choices} translateChoice={false}/>
*
* You can pass 'row={false}' for displaying checkboxes in a row
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean in a column?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I did

@fzaninotto
Copy link
Member

superseded by #3561

@fzaninotto fzaninotto closed this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants