Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent ra-data-graphql-simple from circular dependencies issue #3093

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Prevent ra-data-graphql-simple from circular dependencies issue #3093

merged 1 commit into from
Apr 25, 2019

Conversation

GM-Alex
Copy link
Contributor

@GM-Alex GM-Alex commented Apr 3, 2019

The path prevents the buildFields method from circular dependencies, so that linkedTypes are only processed if they aren't analyzed before.

djhi
djhi requested changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat :) Thanks! Can you add some tests though?

@GM-Alex GM-Alex force-pushed the feature/ra-data-graphql-simple-circular-dependencies branch from 4417608 to 375cfe4 Compare April 5, 2019 20:57
@GM-Alex
Copy link
Contributor Author

GM-Alex commented Apr 5, 2019

@djhi Done. I made a new one but I think we could extend the old one because they are nearly identically.

@fzaninotto fzaninotto merged commit 953be80 into marmelab:master Apr 25, 2019
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 2.9.0 milestone Apr 25, 2019
@lnxmad lnxmad mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GM-Alex @fzaninotto @djhi