Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Upgrade dependencies #3170

Merged
merged 14 commits into from
Apr 30, 2019
Merged

[RFR] Upgrade dependencies #3170

merged 14 commits into from
Apr 30, 2019

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Apr 26, 2019

The goal of this PR is to prepare the transition to react hooks.

  • Upgrade react et react-dom to 18.6
  • Upgrade react-redux to 7.1.0-alpha.1
  • As a consequence, upgrade redux-form to 8.2
  • As a consequence, change react-router-redux to connected-react-router (closes Deprecation of react-router-redux #1999)
  • As a consequence, rename the <Resource context> prop to <Resource intent> (because react-redux now injects a context prop)
  • Fix tests and type warnings
  • Bootstrap Migration guide
  • Upgrade a few dev dependencies (jest, enzyme, rimraf)
  • Upgrade redux-saga reverted that one, it's too much work for now
  • Fix TabbedForm loses values when navigating in tabs
  • Fix CloneButton

@fzaninotto fzaninotto added this to the 3.0.0 milestone Apr 26, 2019
@fzaninotto
Copy link
Member Author

There are still warnings in the console when running the simple and demo examples, but it's working. I'm trying to get rid of them.

@fzaninotto fzaninotto changed the title [BC Break] Upgrade dependencies [BC Break] [WIP] Upgrade dependencies Apr 26, 2019
@fzaninotto
Copy link
Member Author

fzaninotto commented Apr 30, 2019

the CloneButton fails because it uses location.state, which is currently not supported by connected-react-router... (see supasate/connected-react-router#301)

@znk
Copy link

znk commented Apr 30, 2019

Hello @fzaninotto, in your knowledge, is it possible to try this branch' sub-packages with a package manager? e.g yarn add marmelab/react-admin#refs/heads/upgrae-dependencies/<path-to-sub-package>

@fzaninotto
Copy link
Member Author

@znk This is not released yet - not even merged. We don't encourage using unpublished code.

@fzaninotto fzaninotto changed the title [BC Break] [WIP] Upgrade dependencies [BC Break] [RFR] Upgrade dependencies Apr 30, 2019
@djhi djhi merged commit 13aa576 into next Apr 30, 2019
@djhi djhi deleted the upgrae-dependencies branch April 30, 2019 14:34
@fzaninotto fzaninotto changed the title [BC Break] [RFR] Upgrade dependencies [RFR] Upgrade dependencies May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants