Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SimpleFormIterator] add TransitionProps prop #3226

Merged
merged 2 commits into from
Nov 27, 2019

Conversation

cherniavskii
Copy link
Contributor

This PR adds ability to override CSSTransition props.

Together with #3223 adds ability to workaround #3220 in user land:

<ArrayInput source="backlinks">
-  <SimpleFormIterator>
+  <SimpleFormIterator TransitionProps={{ timeout: 400 }}>
    <RichTextInput source="url" />
  </SimpleFormIterator>
</ArrayInput>

qxl29-kwkn8

May be worth to decrease default timeout in the future, but adding ability for workaround is a good first step.

Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! As this is a new feature, can you target the next branch?

@@ -115,6 +115,7 @@ export class SimpleFormIterator extends Component {
translate,
disableAdd,
disableRemove,
TransitionProps,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rename it to transitionProps?

Copy link
Contributor Author

@cherniavskii cherniavskii Jun 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used material-ui naming pattern here - see ExpansionPanel TransitionProps - https://material-ui.com/api/expansion-panel/#props

Maybe it's worth to stick with it?

@cherniavskii
Copy link
Contributor Author

cherniavskii commented Jun 5, 2019

From component's API perspective, it's indeed a new feature.
From the other hand, it's the only way to solve #3220 in user land, which is present on current master.

I'll change target branch to next, but could you please consider cherrypicking it to master branch, so users will have a workaround before react-admin 3.0 release? This change is backwards compatible.

@djhi
Copy link
Contributor

djhi commented Jun 5, 2019

Ok, can you wait for @fzaninotto review then before switching branch ?

@cherniavskii
Copy link
Contributor Author

@djhi sure

@fzaninotto
Copy link
Member

It's indeed a new feature, please PR against next rather than master. The 2.x branch is feature-freeze.

@djhi
Copy link
Contributor

djhi commented Sep 2, 2019

Any news on this one?

@cherniavskii cherniavskii changed the base branch from master to next September 2, 2019 08:49
@djhi djhi added this to the 3.0.0 milestone Sep 2, 2019
@fzaninotto fzaninotto modified the milestones: 3.0.0, 3.1.0 Oct 3, 2019
@djhi djhi merged commit 1ed2b2a into marmelab:next Nov 27, 2019
@djhi
Copy link
Contributor

djhi commented Nov 27, 2019

Thanks!

@cherniavskii cherniavskii deleted the SimpleFormIterator-TransitionProps branch November 27, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants