Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Reset page on per page count change #3257

Merged
merged 2 commits into from
May 21, 2019
Merged

[RFR] Reset page on per page count change #3257

merged 2 commits into from
May 21, 2019

Conversation

sagarbakhtar
Copy link
Contributor

@sagarbakhtar sagarbakhtar commented May 21, 2019 •
edited
Loading

  • Reset page on per page count change
  • Write tests for "SET_PER_PAGE" action

Fixes: #3234

@sagarbakhtar sagarbakhtar changed the title [WIP] Reset page on per page count change [RFR] Reset page on per page count change May 21, 2019
djhi
djhi requested changes May 21, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you ensure you apply our prettier rules?

@sagarbakhtar
Copy link
Contributor Author

@djhi used prettier and updated.

@djhi djhi added this to the 2.9.2 milestone May 21, 2019
@djhi djhi merged commit d04af4c into marmelab:master May 21, 2019
@djhi
Copy link
Contributor

djhi commented May 21, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.2
Development

Successfully merging this pull request may close these issues.

Nothing listed in the list after change the row count per page
2 participants
@sagarbakhtar @djhi