[RFR] [BC Break] Reference hooks cleanup #3446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fzaninotto
commented
Jul 23, 2019
fzaninotto
commented
- Fix ReferenceField (broken by [RFR] Use reference input #3313)
- Use useReferenceInput hook in ReferenceInput component
- Rename useReferenceArray to useReferenceArrayFieldController
- Rename useReferenceMany to usereferenceManyFieldController
- [BC Break] rename isLoaded prop to loaded
And rename it to useReferenceInputController
djhi
reviewed
Jul 24, 2019
| @@ -106,7 +106,7 @@ const LoadedGridList = ({ ids, data, basePath, width }) => { | |||
| ); | |||
| }; | |||
|
|
|||
| const GridList = ({ loadedOnce, ...props }) => | |||
| loadedOnce ? <LoadedGridList {...props} /> : <LoadingGridList {...props} />; | |||
There was a problem hiding this comment.
Isn't it a breaking change too for custom views ?
There was a problem hiding this comment.
Not sure I understand your remark, but yes, it is a breaking change, hence the new section in the upgrade guide.
There was a problem hiding this comment.
The new section says nothing about loadedOnce, only isLoaded
There was a problem hiding this comment.
my bad, it's loadedOnce, not isLoaded. I'll fix the upgrade guide right away.
djhi
requested changes
Jul 24, 2019
djhi
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.