Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] add check for sortable in shouldUpdate #3494

Merged
merged 1 commit into from
Aug 7, 2019
Merged

[RFR] add check for sortable in shouldUpdate #3494

merged 1 commit into from
Aug 7, 2019

Conversation

Kunnu01
Copy link
Contributor

@Kunnu01 Kunnu01 commented Aug 7, 2019

fixes: #2543

@Kunnu01 Kunnu01 changed the title add check for sortable in shouldUpdate [RFR] add check for sortable in shouldUpdate Aug 7, 2019
djhi
djhi approved these changes Aug 7, 2019
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 2.9.6 milestone Aug 7, 2019
@djhi djhi merged commit a178e98 into marmelab:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.6
Development

Successfully merging this pull request may close these issues.

Allow 'sortable' to change dynamically (support it in 'shouldUpdate')
2 participants
@Kunnu01 @djhi