Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Convert filter components to useStyles #3578

Closed
wants to merge 1 commit into from
Closed

[RFR] Convert filter components to useStyles #3578

wants to merge 1 commit into from

Conversation

m4theushw
Copy link
Contributor

@m4theushw m4theushw commented Aug 22, 2019 •
edited
Loading

Related to #3453

  • ra-ui-materialui/src/list/Filter.js
  • ra-ui-materialui/src/list/FilterButton.js
  • ra-ui-materialui/src/list/FilterButtonMenuItem.js
  • ra-ui-materialui/src/list/FilterForm.js

@m4theushw m4theushw changed the title [WIP] Convert filter components to useStyles [RFR] Convert filter components to useStyles Aug 22, 2019
djhi
djhi requested changes Aug 23, 2019
View reviewed changes
packages/ra-ui-materialui/src/list/FilterButton.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/list/FilterButton.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/list/FilterButton.js Outdated Show resolved Hide resolved
packages/ra-ui-materialui/src/list/FilterButton.js Outdated Show resolved Hide resolved
@djhi djhi added this to the 3.0.0 milestone Aug 23, 2019
@fzaninotto
Copy link
Member

This PR now needs rebase

@m4theushw
Copy link
Contributor Author

Changes rebased!

@fzaninotto
Copy link
Member

I've fonverted 3 out of 4 of these components in another PR. Can you rebase so that your PR only converts FilterForm?

@m4theushw
Copy link
Contributor Author

Yes, PR updated.

@fzaninotto
Copy link
Member

Superseded by #3732

@fzaninotto fzaninotto closed this Oct 3, 2019
@fzaninotto fzaninotto removed this from the 3.0.0 milestone Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto requested changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m4theushw @fzaninotto @djhi