[RFR] Ensure Query, Mutation and withDataProvider are backward compatible #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ible Fixes #3593 - [x] Introduced `useDataProviderWithDeclarativeSideEffects` (might need a better name) - [ ] Tests
djhi
changed the title
Luwangel
suggested changes
Aug 28, 2019
| typeof sideEffects === 'undefined' || | ||
| typeof sideEffects === 'function' | ||
| ) { | ||
| return sideEffects; |
There was a problem hiding this comment.
You can test null too. But it's not possible using typeof, because null has type 'object'`.
|
|
||
| return useCallback( | ||
| (type: string, resource: string, params: any, options: any = {}) => { | ||
| const convertToFunctionSideEffect = sideEffects => { |
There was a problem hiding this comment.
I think you can move this method at the top of the file or in another file, and write unit tests.
There was a problem hiding this comment.
No he can't, because the scope of the function must contain the side effects grabbed from hooks just above
There was a problem hiding this comment.
It's not possible to pass them as params?
fzaninotto
requested changes
Aug 28, 2019
packages/ra-core/src/dataProvider/useDataProviderWithDeclarativeSideEffects.ts
Show resolved
Hide resolved
fzaninotto
requested changes
Aug 28, 2019
fzaninotto
approved these changes
Aug 28, 2019
fzaninotto
deleted the
backward-compatible-query-mutation-withdataprovider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3593
useDataProviderWithDeclarativeSideEffects(might need a better name)