[RFR] Introduce useChoices & useSuggestions hook #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Sep 12, 2019
| translateChoice: boolean; | ||
| } | ||
|
|
||
| const useChoices = ({ optionText, optionValue, translateChoice }) => { |
There was a problem hiding this comment.
shouldn't it be singular, useChoice?
djhi
changed the title
It probably won't as I'll keep the existing redundant tests and add almost the same on the new hooks |
fzaninotto
requested changes
Sep 13, 2019
djhi
changed the title
fzaninotto
approved these changes
Sep 15, 2019
This was referenced Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at uniforming choices handling in all components which accept choices.
It provides helper functions to get a choice value and text.
It might have breaking changes for the AutocompleteArrayInput and AutocompleteInput components
Fixes #3630, #2961, #3418, #3098