[RFR] Introduce useGetManyReference hook #3697
Conversation
| pagination: Pagination, | ||
| sort: Sort, | ||
| filter: object, | ||
| source: string, |
There was a problem hiding this comment.
It is used: sent in the payload just like the old call to crudGetManyReference in useReferenceManyFieldController did. See here
There was a problem hiding this comment.
Then I don't understand what it does. And the dataProvider doc doesn't mention it, so I doubt anyone uses it.
| * }; | ||
| */ | ||
| const useGetManyReference = ( | ||
| resource: string, |
There was a problem hiding this comment.
I don't think this should be the first argument, because it's not actually used for the query - just for the storage in the Redux store.
Suggested signature: ('comments', 'post_id', post_id, { page: 1, perPage: 10 }, { field: 'published_at', order: 'DESC' }, 'posts')
And this last argument should probably be called something like "cache_key"
There was a problem hiding this comment.
It's only a part of the cache key
There was a problem hiding this comment.
Besides, I thought it would be better to have the same arguments order as in the other dataProvider hooks
There was a problem hiding this comment.
I think it's confusing, as the actual resource that this hook fetches is the reference. If you think about this hook outside of the context of the ReferenceInputs, it's just a way to get a list of resources wit ha particular filter...
There was a problem hiding this comment.
const useGetManyReference = (
reference: string,
target: string,
id: Identifier,
pagination: Pagination,
sort: Sort,
filter: object,
referencingResource: string,
options?: any
) => { ... }?
packages/ra-core/src/controller/field/useReferenceManyFieldController.ts
Show resolved
Hide resolved
No description provided.