Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @testing-library/react in peerDep on ra-core packages #3851

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Add @testing-library/react in peerDep on ra-core packages #3851

merged 1 commit into from
Oct 21, 2019

Conversation

zyhou
Copy link
Contributor

@zyhou zyhou commented Oct 21, 2019 •
edited
Loading

Can't update from 3.0.0-beta.0 to 3.0.0-beta.2

/app/node_modules/ra-core/esm/util/renderWithRedux.js
Module not found: Can't resolve '@testing-library/react' in '/app/node_modules/ra-core/esm/util'

The issue comes from #3763

@zyhou zyhou added the WIP Work In Progress label Oct 21, 2019
@zyhou zyhou added this to the 3.0.0 milestone Oct 21, 2019
@djhi
Copy link
Contributor

djhi commented Oct 21, 2019 •
edited
Loading

Related #3849 (see comments)

@zyhou zyhou force-pushed the ra-core-add-testinglib-in-peerDep branch from 2cf627a to d589a48 Compare October 21, 2019 12:27
@zyhou zyhou added RFR Ready For Review and removed WIP Work In Progress labels Oct 21, 2019
@fzaninotto fzaninotto merged commit 8cee866 into next Oct 21, 2019
@fzaninotto fzaninotto deleted the ra-core-add-testinglib-in-peerDep branch October 21, 2019 12:50
@kopax
Copy link
Contributor

kopax commented Oct 21, 2019

I thought what the hell is this testing dependencies doing in dependencies, it's supposed to be devDependencies.

I am not sure if moving both to peerDependencies + devDependencies is the right action, perhaps just move it back to dependencies. Sorry about this.

fzaninotto added a commit that referenced this pull request Oct 22, 2019
@fzaninotto
Move @testing-library/react to prod dep of ra-core
07684c0 
Refs #3851
@fzaninotto
Copy link
Member

@kopax I just did that in 07684c0

This was referenced Oct 22, 2019
Closed
Closed
@fzaninotto fzaninotto mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zyhou @djhi @kopax @fzaninotto