[RFR] Fix ReferenceArrayInput does not work in Filters #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Oct 29, 2019
| return { | ||
| choices: dataStatus.choices, | ||
| error: dataStatus.error, | ||
| loaded, | ||
| loading: dataStatus.waiting, | ||
| referenceBasePath, |
There was a problem hiding this comment.
This is never used by child components. It was not passed in 2.0. I think it comes from a bad copy/paste of ReferenceArrayField during the hooks refactoring.
fzaninotto
commented
Oct 29, 2019
| @@ -115,7 +114,7 @@ const useReferenceArrayInputController = ({ | |||
| // the component displaying the currently selected records may fail | |||
| const finalMatchingReferences = | |||
| matchingReferences && matchingReferences.length > 0 | |||
| ? matchingReferences.concat(finalReferenceRecords) | |||
| ? mergeReferences(matchingReferences, finalReferenceRecords) | |||
There was a problem hiding this comment.
This was creating warnings about duplicate keys: selected values that were also in the list of possible choices were displayed twice!
fzaninotto
commented
Oct 29, 2019
| @@ -10,130 +10,6 @@ import LinearProgress from '../layout/LinearProgress'; | |||
| import Labeled from '../input/Labeled'; | |||
| import ReferenceError from './ReferenceError'; | |||
|
|
|||
| const sanitizeRestProps = ({ | |||
There was a problem hiding this comment.
I just moved the View part at the bottom of the file so that the jsDoc appears first. It's easier to read that way.
fzaninotto
commented
Oct 29, 2019
| @@ -262,7 +263,7 @@ const SelectArrayInput: FunctionComponent< | |||
| }; | |||
|
|
|||
| SelectArrayInput.propTypes = { | |||
| choices: PropTypes.arrayOf(PropTypes.object).isRequired, | |||
| choices: PropTypes.arrayOf(PropTypes.object), | |||
There was a problem hiding this comment.
choices are empty when declaring the input in a form:
<ReferenceArrayInput label="Tags" source="tags" reference="tags">
<SelectArrayInput optionText="name" />
</ReferenceArrayInput>
djhi
approved these changes
Oct 29, 2019
This was referenced Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3883