Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleList Skeleton for First Load #4292

Merged
merged 2 commits into from
Jan 15, 2020
Merged

SimpleList Skeleton for First Load #4292

merged 2 commits into from
Jan 15, 2020

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Jan 15, 2020

It adapts depending on :

  • left/right icon/avatar is specified
  • secondary or tertiary text is specified.

SimpleListLoading

@djhi djhi changed the base branch from master to next January 15, 2020 11:01
@djhi djhi added this to the 3.2.0 milestone Jan 15, 2020
@djhi djhi requested a review from fzaninotto January 15, 2020 11:01
@@ -0,0 +1,25 @@
import React, { FC } from 'react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should export this component in index.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@fzaninotto fzaninotto merged commit d6050a2 into next Jan 15, 2020
@fzaninotto fzaninotto deleted the simple-list-loading branch January 15, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants