Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom actions example in List documentation #4327

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

Artexoid
Copy link
Contributor

The previous version of example in documentation was not actual and didn't work in version 3+. I spent an hour to understand it, make a research and get the code from sources. I hope it will help community.

@Artexoid Artexoid requested review from fzaninotto, Luwangel and djhi and removed request for fzaninotto and Luwangel January 21, 2020 16:18
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

docs/List.md Outdated Show resolved Hide resolved
docs/List.md Outdated Show resolved Hide resolved
docs/List.md Outdated Show resolved Hide resolved
docs/List.md Outdated Show resolved Hide resolved
@Artexoid
Copy link
Contributor Author

@fzaninotto updated.

@fzaninotto fzaninotto merged commit 71c2e0d into marmelab:master Jan 22, 2020
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.1.4 milestone Jan 22, 2020
@fzaninotto fzaninotto changed the title Updated an example custom "actions" of component List Fix custom actions example in List documentation Jan 22, 2020
@liviozanol
Copy link

You just saved my soul! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants