-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI for latest version of material-ui #4374
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
approved these changes
Jan 31, 2020
As we upgraded final-form to 4.18.7, it changed the order of priority between the form's initialValues and the field's defaultValue (see final-form/final-form#282). Therefore the test doesn't make sense anymore.
djhi
reviewed
Feb 3, 2020
Luwangel
reviewed
Feb 3, 2020
djhi
approved these changes
Feb 3, 2020
Hi @djhi @fzaninotto , I upgraded my app to the latest version of react-admin, why did the custom filter position turn out like this? Please help. Thanks. |
@guntoroyk see #4389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Material-ui 4.8 changes the menu density by default. But as we added the "dense" prop in react-admin, now the menus are very small...