Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <SimpleListLoading> link style is not implemented error. #4469

Merged
merged 2 commits into from
Mar 4, 2020

Conversation

WiXSL
Copy link
Contributor

@WiXSL WiXSL commented Mar 3, 2020

You get an error using <SimpleListLoading> component :

Material-UI: the key `link` provided to the classes prop is not implemented in undefined.
You can only override one of the following: primary,tertiary. 
    in SimpleListLoading (created by SimpleList)
    in SimpleList (at licencia.js:61)
    in LicenciaList (created by WithPermissions)
    in WithPermissions (created by Router.Consumer)
    in Router.Consumer (created by Route)
    in Route (created by ResourceRoutes)
    in ResourceRoutes (created by Resource)
    in Resource (at App.js:47)
    in App (at src/​index.js:7)`
`link` style is defined in `<SimpleList>`

@fzaninotto
Copy link
Member

The styles for LinkOrNot cannot be overridden by the user. So instead of having one useStyles hook for two components, we'd better have two styles hooks, one for each component.

@WiXSL
Copy link
Contributor Author

WiXSL commented Mar 3, 2020

Well, LinkOrNot is never exported anyways, should I change it to another file and export it as well?
Maybe in another PR?

@fzaninotto
Copy link
Member

No, it's fine like that, thanks.

@fzaninotto fzaninotto merged commit 59ad085 into marmelab:master Mar 4, 2020
@fzaninotto fzaninotto added this to the 3.2.4 milestone Mar 4, 2020
@WiXSL WiXSL deleted the fix-link-class-simple-list branch March 5, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants