Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for allowEmpty=false in Filter Inputs #4500

Merged
merged 3 commits into from
Mar 10, 2020
Merged

Add support for allowEmpty=false in Filter Inputs #4500

merged 3 commits into from
Mar 10, 2020

Conversation

JulienMattiussi
Copy link
Contributor

Closes #4499

Issue

FilterFormInput has always allowEmpty=true despite of input props

Solution

We should allow to have filter not emptiable.

@JulienMattiussi JulienMattiussi added the WIP Work In Progress label Mar 10, 2020
@JulienMattiussi JulienMattiussi changed the base branch from master to next March 10, 2020 11:00
@JulienMattiussi JulienMattiussi changed the title Allow empty in FilterFormInput Add allowEmpty possibility in FilterFormInput Mar 10, 2020
@JulienMattiussi JulienMattiussi added RFR Ready For Review and removed WIP Work In Progress labels Mar 10, 2020
@JulienMattiussi JulienMattiussi added WIP Work In Progress and removed RFR Ready For Review labels Mar 10, 2020
@JulienMattiussi JulienMattiussi added RFR Ready For Review and removed WIP Work In Progress labels Mar 10, 2020
@fzaninotto fzaninotto changed the title Add allowEmpty possibility in FilterFormInput Add support for allowEmpty=false in Filter Inputs Mar 10, 2020
@fzaninotto fzaninotto merged commit 6487594 into next Mar 10, 2020
@fzaninotto fzaninotto deleted the allow-empty-in-filterforminput branch March 10, 2020 16:56
@fzaninotto fzaninotto added this to the 3.4.0 milestone Mar 10, 2020
@fzaninotto fzaninotto mentioned this pull request Mar 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

FilterFormInput always has allowEmpty=true props
2 participants
@JulienMattiussi @fzaninotto