Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useState return type in demo example Dashboard #4590

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Fix useState return type in demo example Dashboard #4590

merged 1 commit into from
Mar 29, 2020

Conversation

developerium
Copy link
Contributor

Hi Guys
I was looking to contribute to converting more of the demo app to typescript and noticed there is a better way to enforce state type.

Please let me know how it looks.

djhi
djhi approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's indeed the right way to do it. Thanks

@fzaninotto fzaninotto changed the title Correct way to enforce state type on demo app Fix useState return type in demo example Dashboard Mar 29, 2020
@fzaninotto fzaninotto merged commit aa851e3 into marmelab:master Mar 29, 2020
@fzaninotto fzaninotto added this to the 3.3.4 milestone Mar 29, 2020
@fzaninotto
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@developerium @fzaninotto @djhi