Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add section about filters in List documentation #4675

Merged
merged 5 commits into from
Apr 10, 2020

Conversation

fzaninotto
Copy link
Member

The "Filter" keyword is the most searched in the react-admin documentation, according to our search engine analytics.

We can probably provide more details about the filtering capabilities of the List component. It's the purpose of this new section.

Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

docs/List.md Outdated
);
```

In the example given above, the `q` filter triggers a full-text search on all fields. It's your responsibility to implement the full-text filtering capabilities in your API.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably be nice to explain the q filter can be handled/converted in the dataProvider as well

docs/List.md Outdated Show resolved Hide resolved
docs/List.md Outdated
);
```

Normally, `showFilter()` enables one filter, but we'll use here to show the entire form.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird sentence

docs/List.md Outdated Show resolved Hide resolved
docs/List.md Outdated Show resolved Hide resolved
fzaninotto and others added 4 commits April 10, 2020 15:51
Co-Authored-By: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Co-Authored-By: Gildas Garcia <1122076+djhi@users.noreply.github.com>
Co-Authored-By: Gildas Garcia <1122076+djhi@users.noreply.github.com>
@jdemangeon jdemangeon merged commit c8cc07a into master Apr 10, 2020
@jdemangeon jdemangeon deleted the filter-documentation branch April 10, 2020 14:04
@jdemangeon jdemangeon added this to the 3.4.1 milestone Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants