Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change id for RadioButtonGroupInputItem to use value rather than label #4928

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Change id for RadioButtonGroupInputItem to use value rather than label #4928

merged 1 commit into from
Jun 11, 2020

Conversation

helenwilliamson
Copy link
Contributor

@helenwilliamson helenwilliamson commented Jun 10, 2020 •
edited by djhi
Loading

Fixes #4924
(as this supports choices rendered as react components)

@helenwilliamson
Change id for RadioButtonGroupInputItem to use value rather than label
0ec66e8 
(as this supports choices rendered as react components)
@helenwilliamson helenwilliamson mentioned this pull request Jun 10, 2020
Closed
djhi
djhi approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@djhi djhi added this to the 3.6.1 milestone Jun 11, 2020
@djhi djhi requested a review from fzaninotto June 11, 2020 06:18
fzaninotto
fzaninotto approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!

@fzaninotto fzaninotto merged commit d4b4c1e into marmelab:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

Ids for radio inputs when using react element for choices is set incorrectly
3 participants
@helenwilliamson @fzaninotto @djhi