Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Fix Export button fails to export data when using default exporter #5032

Merged
merged 1 commit into from
Jul 10, 2020
Merged

[RFR] Fix Export button fails to export data when using default exporter #5032

merged 1 commit into from
Jul 10, 2020

Conversation

fzaninotto
Copy link
Member

@fzaninotto fzaninotto commented Jul 9, 2020 •
edited
Loading

Problem

In a List view with no custom exporter (e.g. the Users list in the simple demo), the export button no longer works

Cause

In 3.7, the ExporterContext was merged into the ListContext, but the default exporter was only set in ExporterContext

@JulienMattiussi JulienMattiussi merged commit 9e30fd9 into master Jul 10, 2020
@JulienMattiussi JulienMattiussi deleted the fix-default-export branch July 10, 2020 09:15
@fzaninotto fzaninotto added this to the 3.7.1 milestone Jul 10, 2020
@Luwangel Luwangel mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @JulienMattiussi