Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full height Layout & Sidebar margins #5111

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Full height Layout & Sidebar margins #5111

merged 2 commits into from
Aug 4, 2020

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Aug 4, 2020

  • Ensure main section takes the full height available by default
  • Move margins from the Sidebar to the Menu

Nothing changes visually by default but it is now easier to have a full height sidebar with a different background. For example:
image

This only requires a little bit of styling using MUI overrides mechanism

@djhi djhi added the RFR Ready For Review label Aug 4, 2020
@Luwangel Luwangel added this to the 3.7.2 milestone Aug 4, 2020
@Luwangel Luwangel changed the title Full height layout & Sidebar margins Full height Layout & Sidebar margins Aug 4, 2020
@Luwangel Luwangel merged commit 792422b into master Aug 4, 2020
@Luwangel Luwangel deleted the full-height-layout branch August 4, 2020 14:28
@djhi djhi mentioned this pull request Aug 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luwangel Luwangel Luwangel approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@djhi @Luwangel