Speed up show & hide filter #5411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the useListController hook returned show and hide filter functions based on the debounced setFilters function. No need to debounce (and to wait for 500 millisecons) to show or hide a filter! This improves filtering in a noticeable way.
EmrysMyrddin
approved these changes
Oct 16, 2020
Comment on lines
+227
to
+234
| const displayedFilters = Object.keys(displayedFilterValues).reduce( | ||
| (filters, filter) => { | ||
| return filter !== filterName | ||
| ? { ...filters, [filter]: true } | ||
| : filters; | ||
| }, | ||
| {} | ||
| ); |
There was a problem hiding this comment.
Perhaps it is more easy to read with a simple loop ?
Suggested change
| const displayedFilters = Object.keys(displayedFilterValues).reduce( | |
| (filters, filter) => { | |
| return filter !== filterName | |
| ? { ...filters, [filter]: true } | |
| : filters; | |
| }, | |
| {} | |
| ); | |
| const displayedFilters = {} | |
| for(filter in displayedFilterValues) { | |
| if(filter !== filterName) displayedFilters[filter] = true | |
| } |
There was a problem hiding this comment.
that's a matter of taste... and I don't particularly like for loops.
Comment on lines
+161
to
+167
| const filters = Object.keys(filterValues).reduce( | ||
| (acc, key) => | ||
| keysToRemove.includes(key) | ||
| ? acc | ||
| : { ...acc, [key]: filterValues[key] }, | ||
| {} | ||
| ); |
There was a problem hiding this comment.
If you are agree with the previous comment, this one can also be written with a loop:
Suggested change
| const filters = Object.keys(filterValues).reduce( | |
| (acc, key) => | |
| keysToRemove.includes(key) | |
| ? acc | |
| : { ...acc, [key]: filterValues[key] }, | |
| {} | |
| ); | |
| const filters = {} | |
| for(filter in filters) { | |
| if(keysToRemove.includes(filter)) filters[key] = filterValues[filter] | |
| } |
djhi
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
useListControllerhook returned show and hide filter functions based on the debounced setFilters function. No need to debounce (and to wait for 500 millisecons) to show or hide a filter!Also, the FiltrListItems (for the ListSidebar) don't need a 500ms delay either.
This improves filtering UX in a noticeable way.