Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix useless AppBar rerenders #5613

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Fix useless AppBar rerenders #5613

merged 4 commits into from
Dec 2, 2020

Conversation

fzaninotto
Copy link
Member

These changers save some rerenders when profiling the simple app using the React profiler. Yet they have no perceivable effects on performance in ms.

So, let's consider this as a cleanup PR.

@fzaninotto fzaninotto added the RFR Ready For Review label Dec 2, 2020
djhi
djhi approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lint warnings and tests fail though

@djhi djhi added this to the 3.10.4 milestone Dec 2, 2020
@djhi djhi merged commit 277fd89 into master Dec 2, 2020
@djhi djhi deleted the list-optims branch December 2, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.10.4
Development

Successfully merging this pull request may close these issues.
2 participants
@fzaninotto @djhi