Fix Filter fails to show compound filters with no default value #5657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
commented
Dec 11, 2020
| @@ -246,7 +246,9 @@ const useListParams = ({ | |||
| ...displayedFilterValues, | |||
| [filterName]: true, | |||
| }; | |||
| const filter = set(filterValues, filterName, defaultValue); | |||
| const filter = defaultValue | |||
There was a problem hiding this comment.
The problem was with compound filters (e.f. 'comment.title') with no default value. set returned {comment: {}}, which is wrong in that case.
djhi
requested changes
Dec 11, 2020
| describe('showFilter', () => { | ||
| it('should initialize displayed filters', () => { | ||
| const TestedComponent = () => { | ||
| const [_, { showFilter }] = useListParams({ |
There was a problem hiding this comment.
You don't need the _, just leave the slot it empty
Suggested change
| const [_, { showFilter }] = useListParams({ | |
| const [, { showFilter }] = useListParams({ |
|
|
||
| it('should initialize displayed filters on compound filters', () => { | ||
| const TestedComponent = () => { | ||
| const [_, { showFilter }] = useListParams({ |
There was a problem hiding this comment.
Same
Suggested change
| const [_, { showFilter }] = useListParams({ | |
| const [, { showFilter }] = useListParams({ |
|
|
||
| it('should initialize filters on compound filters', () => { | ||
| const TestedComponent = () => { | ||
| const [_, { showFilter }] = useListParams({ |
There was a problem hiding this comment.
Same
Suggested change
| const [_, { showFilter }] = useListParams({ | |
| const [, { showFilter }] = useListParams({ |
djhi
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5653