Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type of Exporter #5782

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Fix return type of Exporter #5782

merged 1 commit into from
Jan 15, 2021

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Jan 15, 2021

ref #5771 (comment)

The return type of Exporter has been wrong, this pull request fixes it.

@ohbarye ohbarye mentioned this pull request Jan 15, 2021
Closed
djhi
djhi approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Thanks!

@djhi djhi added this to the 3.11.3 milestone Jan 15, 2021
@djhi djhi merged commit 3bf2f13 into marmelab:master Jan 15, 2021
@ohbarye ohbarye deleted the patch-2 branch January 15, 2021 06:10
@ohbarye
Copy link
Contributor Author

ohbarye commented Jan 15, 2021

thanks for your quick review too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djhi djhi djhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ohbarye @djhi