Fix DeleteWithConfirmButton Does Not Allow to Override resource #5884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Feb 11, 2021
| @@ -184,6 +184,7 @@ const Toolbar: FC<ToolbarProps> = props => { | |||
| button.props.undoable, | |||
| undoable | |||
| ), | |||
| ...button.props, | |||
There was a problem hiding this comment.
I don't understand this line. When we clone button, we clone it wit hits props. some are overridden starting at line 164, but when there is a possibility to set it directly on the button element, we use the valueOrDefault util. I think this is what you should do for the resource prop.
fzaninotto
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5869