Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] chore(apollo): migrate to apollo 3 #6327

Closed
wants to merge 1 commit into from

Conversation

Oupsla
Copy link
Contributor

@Oupsla Oupsla commented Jun 3, 2021

Hello folks 👋

Apollo packages are now deprecated and everything has been centralized to single package on npm (@apollo/client)

Little note : IntrospectionFragmentMatcher has been removed totally (link) , so I have just removed it (tested with my project without errors, so I think the issue linked in the code is gone with apollo3)

@Oupsla Oupsla changed the title chore(apollo): migrate to apollo 3 [RFR] chore(apollo): migrate to apollo 3 Jun 3, 2021
@djhi
Copy link
Contributor

djhi commented Jun 3, 2021

Thanks! We'll have to migrate the json-graphql-server package as well though

@Oupsla
Copy link
Contributor Author

Oupsla commented Jun 7, 2021

Thanks! We'll have to migrate the json-graphql-server package as well though

Do I need to do something else in this PR ?

@djhi
Copy link
Contributor

djhi commented Jun 7, 2021

I don't think so but we won't merge before being able to test it and that means we'll have to migrate json-graphql-server first.

@julien1619
Copy link

Hello! I've started working on the same thing a week ago after seeing #6312 but didn't see your PR until today.

You can remove graphql-tag too and use import { gql } from "@apollo/client" instead as I did here: https://github.com/marmelab/react-admin/pull/6347/files

Like I said in the other PR, before being merged it would need an upgrade of ra-data-graphql-simple.
I tried to upgrade it too, but it mainly depends on a dead fork of a dead project (last commit 2018), depending on an outdated version of graphql (0.11).

@julien1619
Copy link

Is there anything I can do to help here?

@larsivi
Copy link

larsivi commented Aug 22, 2021

I am starting to have other dependencies that also rely on Apollo 3, supporting both in the application is not easy. I am also willing to help here if necessary to expedite this issue.

@Oupsla
Copy link
Contributor Author

Oupsla commented Aug 23, 2021

Coming back from vacation, will have a look at it asap

@djhi
Copy link
Contributor

djhi commented Sep 24, 2021

Thanks, I opened a new PR fixing both packages. We also upgraded json-graphql-server.

@djhi djhi closed this Sep 24, 2021
@Oupsla Oupsla deleted the chore/apollo3 branch September 24, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants