Fixed number input label issue #6361
Conversation
| /> | ||
| label !== '' && | ||
| label !== false && ( | ||
| <FieldTitle |
There was a problem hiding this comment.
It would probably be better to handle this in FieldTitle directly. Then we would only have to update the propTypes in all the other components
There was a problem hiding this comment.
Handled label issue directly inside FieldTitle. Updated propType for NumberInput field.
I will raise separate PR to update label propType in other components. Will it be fine?
Let me know if any changes required.
Thanks..!
There was a problem hiding this comment.
Please update the propTypes and TypeScript types in this PR
|
Thanks! |
There was a problem hiding this comment.
Thanks for your PR.
You should also refactor TextInput, SelectInput and RichTextInput to remove the test on label !== false, which is now redundant.
You should document that feature in the Input documentation.
Finally, this is technically a new feature, and as such it should be PRed against next rather than master.
| @@ -18,9 +18,15 @@ export const FieldTitle: FunctionComponent<Props> = ({ | |||
| isRequired, | |||
| }) => { | |||
| const translate = useTranslate(); | |||
|
|
|||
| if (label === false && label === '') { | |||
There was a problem hiding this comment.
Ok. So the desired behavior is to return null only if label is false. Right? Correct me if I am wrong.
There was a problem hiding this comment.
I just followed below existing code -
https://github.com/marmelab/react-admin/blob/master/packages/ra-ui-materialui/src/input/TextInput.tsx#L65
As per this code, FieldTitle will not get rendered if string is empty.
There was a problem hiding this comment.
my bad, you're right. Both '' and false should disable the title.
| expect(container.firstChild).toBeNull(); | ||
| }); | ||
|
|
||
| it('should return null if label is empty string', () => { |
There was a problem hiding this comment.
This isn't the desired behavior. An empty string should lead to an empty label (not the absence of label)
…dmin into number-input-label-issue
|
Closes #6352
Fixed label issue for Number input.
Before - with
label={false}