Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simple codesandbox #6781

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Fix simple codesandbox #6781

merged 1 commit into from
Nov 15, 2021

Conversation

djhi
Copy link
Contributor

@djhi djhi commented Nov 15, 2021

Closes #6772

@djhi djhi added the RFR Ready For Review label Nov 15, 2021
@djhi djhi added this to the 3.19.1 milestone Nov 15, 2021
@fzaninotto
Copy link
Member

don't we have to push an update to the yarn.lock, too?

@djhi
Copy link
Contributor Author

djhi commented Nov 15, 2021

Nope because we already had this dependency for the demos

@fzaninotto fzaninotto merged commit 2f53edd into master Nov 15, 2021
@fzaninotto fzaninotto deleted the fix-simple-codesandbox branch November 15, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.19.1
Development

Successfully merging this pull request may close these issues.

Fork of codesandbox doesn't compile
2 participants
@djhi @fzaninotto