-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce the Engine
abstraction.
#157
Conversation
31ce812
to
ccafa2a
Compare
This will allow users to plug different implementations in to the rest of the API. While I'm touching almost everything and breaking backwards compatibility, a bunch of renaming and cleanup was also done.
ccafa2a
to
78619fb
Compare
@dingelish How does this look for creating a new |
sure. i'd create another PR :-) thank you! |
hey @marshallpierce how's it going! the security researchers have disclosed the CVE vulnerability |
Yep, I saw that, and wondered if that was related. :) Did you get a chance to implement a constant-time |
haven't start implementing |
Let's get this done. I'll review this engine pr (perhaps some API changes will jump out at me after a few months' absence). |
also a few other Config tweaks
6fbe921
to
394a47a
Compare
Not useful yet since unwrap() and friends aren't const, but some future rust version can make use of it.
394a47a
to
3c62bd4
Compare
- Improve engine tests - Improve comments - Remove dead code - Improve error message byte formatting
cool! i'll work on this tonight! |
@marshallpierce should i create another Engine or add some feature gates on the current |
I think a new engine would be the way to go -- hopefully a simpler mechanism for users to choose from. |
This will allow users to plug different implementations in to the rest of the API.
While I'm touching almost everything and breaking backwards compatibility, a bunch of renaming and cleanup was also done.