Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

87 show personalized favorites #131

Merged
merged 62 commits into from
May 14, 2022
Merged

87 show personalized favorites #131

merged 62 commits into from
May 14, 2022

Conversation

JacobBredin
Copy link
Collaborator

@JacobBredin JacobBredin commented May 9, 2022 •
edited by martinjonsson01
Loading

Summary

Favorites are now saved in the database for each user separately. Favorites are also shown to users based on what they have favorited themselves.

image

(images via SQL Server Management Studio)
image
image

Definition of done

  • All acceptance criteria are completed.
  • The code has (at least) 80% branch test coverage.
  • All tests pass.
  • The code is reviewed and accepted by (at least) two other team members.
  • Views adhere to design style.

Closes #87

JacobBredin and others added 26 commits May 7, 2022 14:21
@JacobBredin @pkasinski
Add UserContract table to database
351f12a 
Co-authored-by: pkasinski <kasinski@student.chalmers.se>
@JacobBredin @pkasinski
Add services and infrastructure
71ad5b3 
Co-authored-by: pkasinski <kasinski@student.chalmers.se>
@JacobBredin @pkasinski
Add server side endpoints
341f881 
Co-authored-by: pkasinski <kasinski@student.chalmers.se>
@JacobBredin @pkasinski
Add client endpoints
2df1222 
Co-authored-by: pkasinski <kasinski@student.chalmers.se>
@JacobBredin @pkasinski
Fix broken tests
eb4c535 
Co-authored-by: pkasinski <kasinski@student.chalmers.se>
@JacobBredin @pkasinski
Remove IsFavorite from contract
f0fd186 
Co-authored-by: pkasinski <kasinski@student.chalmers.se>
@pkasinski
Fix documentation
44485ba
@pkasinski
Remove unnecessary method from FavoritesController
ec3928d
@pkasinski
Rename methods in FavoritesController
c2c24b0
@JacobBredin @pkasinski
Move unit tests to separate files
c807fc1 
Co-authored-by: pkasinski <kasinski@student.chalmers.se>
@JacobBredin
Merge branch '87-show-personalized-favorites-2' of https://github.com…
2c5f846 
…/martinjonsson01/contract-portal into 87-show-personalized-favorites-2
@JacobBredin
Incomplete tests for FavoritesController
4e745bf
@pkasinski
Add tests to FavoriteContractServiceTests
dac7dfa
@JacobBredin
Add FavoriteButton unit tests
fbc8178
@JacobBredin
Merge branch '87-show-personalized-favorites-2' of https://github.com…
87c7d3b 
…/martinjonsson01/contract-portal into 87-show-personalized-favorites-2
@JacobBredin
Fix incorrect logger in EFFavoriteRepository
9e69123
@pkasinski
Change a test in FavoriteContractServiceTests
8b60139
@pkasinski
Rename method in FavoritesController
10bf183
@pkasinski
Add tests to FavoritesControllerTests
5dc8b76
@JacobBredin
Add exception handling
b185b5b
@JacobBredin
Add unit tests
c7aa5a7
@JacobBredin
Merge branch '87-show-personalized-favorites-2' of https://github.com…
ca74421 
…/martinjonsson01/contract-portal into 87-show-personalized-favorites-2
@JacobBredin
Add and fix unit tests
bb75820
@JacobBredin
Add exception handling to FavoritesController
d4573e4
@JacobBredin
Add migration for removing IsFavorite in contract
672125d
@JacobBredin
Merge master into branch
7607af5
jonathan-lindqvist
jonathan-lindqvist approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@jonathan-lindqvist jonathan-lindqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! 👍

Nothing to comment on that has not already been mentioned

martinjonsson01
martinjonsson01 approved these changes May 12, 2022
View reviewed changes
Copy link
Owner

@martinjonsson01 martinjonsson01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

src/Application/Users/IUserService.cs Show resolved Hide resolved
src/Client/Pages/Dashboard/FavoriteCards.razor Outdated Show resolved Hide resolved
tests/Client.Tests/Pages/Contracts/FavoriteButtonTests.cs Outdated Show resolved Hide resolved
tests/Client.Tests/Pages/Contracts/FavoriteButtonTests.cs Outdated Show resolved Hide resolved
tests/Client.Tests/Pages/Contracts/FavoriteButtonTests.cs Outdated Show resolved Hide resolved
tests/Client.Tests/Pages/Contracts/FavoriteButtonTests.cs Outdated Show resolved Hide resolved
@JacobBredin JacobBredin force-pushed the 87-show-personalized-favorites-2 branch from 4e10a39 to 038569b Compare May 12, 2022 15:15
@JacobBredin JacobBredin merged commit d38d743 into master May 14, 2022
@JacobBredin JacobBredin deleted the 87-show-personalized-favorites-2 branch May 14, 2022 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjonsson01 martinjonsson01 martinjonsson01 approved these changes

@pkasinski pkasinski pkasinski left review comments

@jonathan-lindqvist jonathan-lindqvist jonathan-lindqvist approved these changes

@XwayTomy XwayTomy XwayTomy approved these changes

@Matte02 Matte02 Awaiting requested review from Matte02

@ellsib ellsib Awaiting requested review from ellsib

@Gigset Gigset Awaiting requested review from Gigset

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show personalized favorites
5 participants
@JacobBredin @martinjonsson01 @jonathan-lindqvist @XwayTomy @pkasinski