Fetch descendants more correctly.

See context in [this discussion](#3935 (comment)) Fixes #3947
martinvonz · Aug 24, 2024 · d09e424 · d09e424
1 parent fe7a206
commit d09e424
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/cli/src/movement_util.rs b/cli/src/movement_util.rs
@@ -143,16 +143,20 @@ impl Direction {
         args: &MovementArgsInternal,
     ) -> Result<Rc<RevsetExpression>, CommandError> {
         let target_revset = match self {
-            Direction::Next => if args.conflict {
-                start_revset
-                    .children()
-                    .descendants()
-                    .filtered(RevsetFilterPredicate::HasConflict)
-                    .roots()
-            } else {
-                start_revset.descendants_at(args.offset)
+            Direction::Next => {
+                if args.conflict {
+                    start_revset
+                        .children()
+                        .minus(working_revset)
+                        .descendants()
+                        .filtered(RevsetFilterPredicate::HasConflict)
+                        .roots()
+                } else {
+                    start_revset
+                        .descendants_at(args.offset)
+                        .minus(working_revset)
+                }
             }
-            .minus(working_revset),
 
             Direction::Prev => {
                 if args.conflict {