-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
commit: add --reset-author
option
#3998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, it also makes sense if you read commit
as desc + new
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be okay for jj commit
to always reset author (or timestamp at least.) Is that surprising?
I think this might be surprising, since as @PhilipMetzger said, I tend to think of Are there any existing cases where the behavior is different for |
No, I don't think so (except for splitting.) I just thought it might make sense to people coming from other VCSs if |
Yeah, it does seem like it would better match the expectations of new users coming from Git. One concern I have is that new users might also use If we update I'm curious how many Git users actually know that there's separate author and committer timestamps. It could be the case that most people don't even know/care how it works in Git, in which case it wouldn't matter that jj behaves differently. |
Let's not change the meaning of |
I wouldn't consider |
My anecdotal experience is that most Git users barely think about timestamps at all. |
8d203e3
to
4575402
Compare
Since
jj describe --reset-author
works, I also expectedjj commit --reset-author
to work, so I think this would be a good option to add.Checklist
If applicable:
CHANGELOG.md