Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept early args after help command #4518

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Accept early args after help command #4518

wants to merge 2 commits into from
+81 −2

Conversation

Grillo-0
Copy link

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@Grillo-0
cli_util: Remove unnecessary value_name attribute to no_pager flag
1f34478 
The value_name is not necessary for boolean flags.
@Grillo-0
cli: Explicitly add a Help command to accept the early args after it
2c508a3 
The default clap's help command doesn't have the ability to accept flags
(e.g --no-pager). The recommended way[1] to solve this is to manually
implement it.

[1]: clap-rs/clap#5332

Fixes: martinvonz#4501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Grillo-0