Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct rust_hdl library installation #6140

Merged

Conversation

Shivlocin
Copy link
Contributor

@Shivlocin Shivlocin commented Jun 16, 2024

Describe your changes

rust_hdl installation instructions did not include the libraries required

Issue ticket number and link

#6139

Checklist before requesting a review

  • I have successfully tested installation of the package.
  • I have successfully tested the package after installation.

Screenshots

image.

image

@williambotman williambotman requested a review from a team June 16, 2024 04:28
@Shivlocin
Copy link
Contributor Author

Unfortunately I do not have a windows or linux machine readily available for testing. I have tested on macos.

Copy link
Member

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think it'd be better to avoid path components such as ./, and we can move the trailing slash to the where the paths are defined

packages/rust_hdl/package.yaml Outdated Show resolved Hide resolved
packages/rust_hdl/package.yaml Outdated Show resolved Hide resolved
packages/rust_hdl/package.yaml Outdated Show resolved Hide resolved
packages/rust_hdl/package.yaml Outdated Show resolved Hide resolved
@williamboman williamboman merged commit ae6dcf8 into mason-org:main Jul 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants