Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add superhtml package #6579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EliSauder
Copy link

@EliSauder EliSauder commented Jul 23, 2024

Describe your changes

Added the superhtml lsp to the list of packages that mason can install.

Issue ticket number and link

Checklist before requesting a review

  • I have successfully tested installation of the package.
  • I have successfully tested the package after installation.

Screenshots

Example using mason-lspconfig (PR coming soon)
image

LSP Showint up in :LspInfo
image

Installed through Mason
image
image

Not quite ready for prime time since the LSP itself doesn't fully work yet (that or I've set it up wrong) kristoff-it/superhtml#20.

@EliSauder
Copy link
Author

EliSauder commented Jul 26, 2024

This should be ready to go now. superhtml has been upversioned to v0.4.3, fixes have been added and some misconfiguration dealt with in the lspconfig PR so that it now all works.

@EliSauder EliSauder marked this pull request as ready for review July 26, 2024 15:07
@EliSauder
Copy link
Author

Some other updates, the superhtml filetype has been added to the vim and neovim repositories, here is the neovim patch: neovim/neovim@e596b6a

@EliSauder
Copy link
Author

@williamboman hello, I do apologize for the ping, but this has been sitting getting stale for a while. I was wondering if there is anything else that I can do to help move this along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant