-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed move worker getting locale from remote account #16576
Fixed move worker getting locale from remote account #16576
Conversation
Seems simple enough to deal with missing data but I wonder why it would be missing. Is there an issue related to this? |
There are no related issues. This is a port from Fedibird that fixes the actual error-prone worker found in sidekiq's dead jobs. A remote account may be specified for MoveWorker. The remote account has no data in the associated user table. If you refer to this, it will be nil. I get an error because nil doesn't have a locale method. |
Hmmm, I actually don't understand how this could happen:
EDIT: oh, unless the issue is not with remote accounts but with deleted accounts (that keep the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, great catch! This may well be the issue I failed to diagnose a while ago when I wrote #16415
EDIT: even better might be to just return early and do nothing if account.user
is nil
.
No description provided.