Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types param to GET /api/v1/notifications in REST API #17767

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Add types param to GET /api/v1/notifications in REST API #17767

merged 2 commits into from
Mar 15, 2022

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Mar 14, 2022

Instead of specifying every known type to exclude, you can specify only the types you want.

@Gargron Gargron added the api REST API, Streaming API, Web Push API label Mar 14, 2022
ClearlyClaire
ClearlyClaire requested changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some tests got inadequately changed, but otherwise it looks good to me.

spec/controllers/api/v1/notifications_controller_spec.rb Outdated Show resolved Hide resolved
spec/controllers/api/v1/notifications_controller_spec.rb Outdated Show resolved Hide resolved
@ClearlyClaire
Copy link
Contributor

ClearlyClaire commented Mar 14, 2022 via email

@Gargron Gargron merged commit e6ffbfb into main Mar 15, 2022
@Gargron Gargron deleted the feature-notification-types-param branch March 15, 2022 03:11
MainasuK added a commit to mastodon/mastodon-ios that referenced this pull request May 26, 2022
@MainasuK
fix: notification includes admin mod type issue
fceee88 
ref: mastodon/mastodon#17767
@MainasuK MainasuK mentioned this pull request May 26, 2022
Merged
@MainasuK MainasuK mentioned this pull request Jul 1, 2022
Merged
@ahox ahox mentioned this pull request Nov 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire Awaiting requested review from ClearlyClaire

Assignees
No one assigned
Labels
api REST API, Streaming API, Web Push API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gargron @ClearlyClaire